Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10500 )
Change subject: KUDU-2191: Metadata Downgrade Tool ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/10500/2/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/10500/2/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@140 PS2, Line 140: table 'tables' http://gerrit.cloudera.org:8080/#/c/10500/2/src/kudu/hms/hms_catalog.h File src/kudu/hms/hms_catalog.h: http://gerrit.cloudera.org:8080/#/c/10500/2/src/kudu/hms/hms_catalog.h@102 PS2, Line 102: DowngradeLegacyImpalaTable Might be more clear to name it "DowngradeToLegacyImpalaTable" http://gerrit.cloudera.org:8080/#/c/10500/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/10500/2/src/kudu/tools/kudu-tool-test.cc@2188 PS2, Line 2188: cluster_->EnableMetastoreIntegration(); Isn't it already enabled on line 2157? http://gerrit.cloudera.org:8080/#/c/10500/2/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10500/2/src/kudu/tools/tool_action_hms.cc@281 PS2, Line 281: Status HmsDowngrade(const RunnerContext& context) { Do you think it's worth adding a TODO about checking that the HMS integration isn't enabled when this is run? -- To view, visit http://gerrit.cloudera.org:8080/10500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieac752e5c1fe5e63bc1ad5455b2c5dba8d3deba5 Gerrit-Change-Number: 10500 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 20 Jun 2018 18:24:49 +0000 Gerrit-HasComments: Yes
