Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10783 )
Change subject: Synchronizer::WaitFor thread-safety ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/10783/2/src/kudu/util/async_util-test.cc File src/kudu/util/async_util-test.cc: http://gerrit.cloudera.org:8080/#/c/10783/2/src/kudu/util/async_util-test.cc@41 PS2, Line 41: class AsyncUtilTest : public KuduTest { > Looks good, but why not add it to the test fixture's constructor/destructor Done http://gerrit.cloudera.org:8080/#/c/10783/2/src/kudu/util/async_util-test.cc@46 PS2, Line 46: } > Oh, I see. I missed that in the first pass. Could you add DISALLOW_COPY_AND Good idea, done. -- To view, visit http://gerrit.cloudera.org:8080/10783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9565a50839ffd23b5bac6986a6fdee41ac21aa3a Gerrit-Change-Number: 10783 Gerrit-PatchSet: 5 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 20:32:41 +0000 Gerrit-HasComments: Yes
