Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10808 )
Change subject: java: Expose test name in BaseKuduTest ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10808/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10808/1//COMMIT_MSG@12 PS1, Line 12: We also use the method name for the default test table name in : TestKuduClient instead of a timestamp, since relying on a timestamp for : uniqueness might be racy. I was under the impression that the addition of the timestamp is to facilitate retrying the test. AFAIK, when surefire/failsafe retry a failed test, they do so without running @BeforeClass/@AfterClass annotated methods. BaseKuduTest resets the minicluster state in @BeforeClass/@AfterClass methods, so the cluster state remains the same during the retry, and if there's nothing "pseudo-random" in the table name, an attempt to create the table again will fail. Of course, this dates back to when we had separate minicluster code for Java which did stupid things like arbitrary Thread.sleep() calls, thus unnecessarily increasing test latency. Now that we're wrapping the C++ minicluster, we should transition cluster state management to @Before/@After so we won't need to resort to hacks like this in the first place. -- To view, visit http://gerrit.cloudera.org:8080/10808 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63049288e1ab6b32fe629a5c009f2d7d523fd5c0 Gerrit-Change-Number: 10808 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Sat, 23 Jun 2018 16:31:42 +0000 Gerrit-HasComments: Yes
