Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10817 )

Change subject: WIP: KUDU-2191: support table-name identifiers with upper case 
chars
......................................................................


Patch Set 2:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/10817/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10817/1//COMMIT_MSG@17
PS1, Line 17: can not be
            : alter
> can
Done


http://gerrit.cloudera.org:8080/#/c/10817/1//COMMIT_MSG@18
PS1, Line 18: the HMS
> ^ when the HMS integration is enabled.
Done


http://gerrit.cloudera.org:8080/#/c/10817/1//COMMIT_MSG@28
PS1, Line 28: og meta
> entry
Done


http://gerrit.cloudera.org:8080/#/c/10817/1//COMMIT_MSG@29
PS1, Line 29: by-na
> ^ ephemeral
Done


http://gerrit.cloudera.org:8080/#/c/10817/1//COMMIT_MSG@31
PS1, Line 31: name. Wh
> ^ When the HMS integration is not configured, normalized table names are si
Done


http://gerrit.cloudera.org:8080/#/c/10817/1//COMMIT_MSG@39
PS1, Line 39: les be
> should be braces
Done


http://gerrit.cloudera.org:8080/#/c/10817/1//COMMIT_MSG@48
PS1, Line 48:
> name
Done


http://gerrit.cloudera.org:8080/#/c/10817/1/src/kudu/hms/hms_catalog-test.cc
File src/kudu/hms/hms_catalog-test.cc:

http://gerrit.cloudera.org:8080/#/c/10817/1/src/kudu/hms/hms_catalog-test.cc@108
PS1, Line 108: UMPS/
> jumps
Done



--
To view, visit http://gerrit.cloudera.org:8080/10817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18977d6fe7b2999a36681a728ac0d1e54b7f38cd
Gerrit-Change-Number: 10817
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Tue, 26 Jun 2018 21:11:48 +0000
Gerrit-HasComments: Yes

Reply via email to