Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10831 )
Change subject: KUDU-2191: reject alter table rename to same table name ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10831/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/10831/1/src/kudu/master/catalog_manager.cc@2153 PS1, Line 2153: // however Kudu does not, so we must validate this case ourselves. > Not sure I follow, his validation will be returned to the client. This is I mean we already have a validation in L2284. My understanding is that we need to add this validation because the one in L2284 cannot bubble up with HMS integration enabled. But maybe my understanding is not correct? -- To view, visit http://gerrit.cloudera.org:8080/10831 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d895bcc98cbc45a27ff25e97a25436273d79b0 Gerrit-Change-Number: 10831 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 27 Jun 2018 00:30:20 +0000 Gerrit-HasComments: Yes
