Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10824 )
Change subject: [Java] Support re-running tests in the Gradle build ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10824/2/java/kudu-client/src/test/java/org/apache/kudu/junit/RetryRule.java File java/kudu-client/src/test/java/org/apache/kudu/junit/RetryRule.java: http://gerrit.cloudera.org:8080/#/c/10824/2/java/kudu-client/src/test/java/org/apache/kudu/junit/RetryRule.java@26 PS2, Line 26: public class RetryRule implements TestRule { What are the semantics of retrying in this way w.r.t. methods annotated with @{Before,After}Class and @{Before,After}? AFAIK, surefire/failsafe's retry logic will invoke @Before/@After but not @BeforeClass/@AfterClass in between retries. Does this do the same thing? I think it's important for surefire/failsafe and Gradle to have the same semantics. If we can't get them to match, one possibility is to stop using the built-in retry logic in surefire/failsafe and use RetryRule in those executors too. -- To view, visit http://gerrit.cloudera.org:8080/10824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie11e61c40ee991b00616012f0decaaf2c5fe5ef0 Gerrit-Change-Number: 10824 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 27 Jun 2018 22:22:02 +0000 Gerrit-HasComments: Yes
