Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10833 )
Change subject: KUDU-2480: master-stress-test: increase effective DDL timeout ...................................................................... Patch Set 2: (1 comment) Sorry I missed this earlier. http://gerrit.cloudera.org:8080/#/c/10833/2/src/kudu/integration-tests/master-stress-test.cc File src/kudu/integration-tests/master-stress-test.cc: http://gerrit.cloudera.org:8080/#/c/10833/2/src/kudu/integration-tests/master-stress-test.cc@160 PS2, Line 160: // The C++ client currently uses the normal RPC timeout to retry DDL : // operations to alternate masters, which effectively reduces the admin : // timeout to the RPC timeout. With HMS integration some DDL operations can : // exceed the default 10s timeout. : builder.default_rpc_timeout(MonoDelta::FromSeconds(30)); So shouldn't this be conditioned on the value of GetParam()? -- To view, visit http://gerrit.cloudera.org:8080/10833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45b604aaf3e51756af564aefbcb1300051076d3e Gerrit-Change-Number: 10833 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 27 Jun 2018 22:53:52 +0000 Gerrit-HasComments: Yes
