Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 )
Change subject: KUDU-2420: Support parallel java tests ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG@7 PS1, Line 7: KUDU-2420: Support parallel java tests > Yeah, that'd be a good idea. You can file a JIRA too if there's too much fo I filed KUDU-2489 http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java: http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@55 PS1, Line 55: // Expose the MiniKuduCluster builder so that subclasses can alter the builder. : protected static final MiniKuduCluster.MiniKuduClusterBuilder miniClusterBuilder = : new MiniKuduCluster.MiniKuduClusterBuilder(); : : // Comma separate describing the master addresses and ports. : protected static String masterAddresses; : protected static List<HostAndPort> masterHostPorts; : : // We create both versions of the client for ease of use. : protected static AsyncKuduClient client; : protected static KuduClient syncClient; : protected static final Schema basicSchema = getBasicSchema(); : protected static final Schema allTypesSchema = getSchemaWithAllTypes(); > OK, though the suggestion I'm recommending would mean rewriting all those n Fair enough. I will update the patch to remove the static usage. http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java: http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@118 PS1, Line 118: tempRoot.deleteOnExit(); > There's this code in tool_action_test.cc: Interesting. Early on when working on this I though I had cluster state left behind. I tested it again and checked the output directories and they are in fact cleaned up. -- To view, visit http://gerrit.cloudera.org:8080/10838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371 Gerrit-Change-Number: 10838 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 29 Jun 2018 15:12:33 +0000 Gerrit-HasComments: Yes
