Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10875 )
Change subject: KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10875/1/src/kudu/util/net/socket.cc File src/kudu/util/net/socket.cc: http://gerrit.cloudera.org:8080/#/c/10875/1/src/kudu/util/net/socket.cc@252 PS1, Line 252: return Status::OK(); > I think it'd be better to return an error status if SO_REUSEPORT isn't set, Done -- To view, visit http://gerrit.cloudera.org:8080/10875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I673fa09619955de162e2e2742480672b1e5c4d1d Gerrit-Change-Number: 10875 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Fri, 06 Jul 2018 00:12:52 +0000 Gerrit-HasComments: Yes
