Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10878 )
Change subject: loadgen: honor table_num_replicas contract ...................................................................... loadgen: honor table_num_replicas contract The description for table_num_replicas says that a value of 0 means use the server-side default. Except that if you try to use 0 right now, you'll get an error: "illegal replication factor 0 (replication factor must be odd)". Passing 0 all the way to the server is rightfully an error; to get the server-side default, the client needs to leave this field blank. Change-Id: Ia978b266e4a81a35495e6366f8938ac337c3645c Reviewed-on: http://gerrit.cloudera.org:8080/10878 Tested-by: Kudu Jenkins Reviewed-by: Will Berkeley <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_perf.cc 2 files changed, 8 insertions(+), 3 deletions(-) Approvals: Kudu Jenkins: Verified Will Berkeley: Looks good to me, approved Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/10878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia978b266e4a81a35495e6366f8938ac337c3645c Gerrit-Change-Number: 10878 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]>
