Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10920 )

Change subject: [tools] sanity check for ScheduleReplicaMove()
......................................................................


Patch Set 2:

(7 comments)

Nits.

http://gerrit.cloudera.org:8080/#/c/10920/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10920/2//COMMIT_MSG@11
PS2, Line 11: :
nit: extra ':'?


http://gerrit.cloudera.org:8080/#/c/10920/2//COMMIT_MSG@18
PS2, Line 18: in the middle
In the middle of what?


http://gerrit.cloudera.org:8080/#/c/10920/2//COMMIT_MSG@20
PS2, Line 20: in re-setting
to reset


http://gerrit.cloudera.org:8080/#/c/10920/2//COMMIT_MSG@23
PS2, Line 23: test
tests


http://gerrit.cloudera.org:8080/#/c/10920/2//COMMIT_MSG@23
PS2, Line 23: already
Replace with "the".


http://gerrit.cloudera.org:8080/#/c/10920/2/src/kudu/tools/tool_replica_util.cc
File src/kudu/tools/tool_replica_util.cc:

http://gerrit.cloudera.org:8080/#/c/10920/2/src/kudu/tools/tool_replica_util.cc@354
PS2, Line 354:
Insert "be".


http://gerrit.cloudera.org:8080/#/c/10920/2/src/kudu/tools/tool_replica_util.cc@356
PS2, Line 356:
insert "us".



--
To view, visit http://gerrit.cloudera.org:8080/10920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie311b4bb2dbe3e5f1e86cb1364039b71d7c08019
Gerrit-Change-Number: 10920
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Wed, 11 Jul 2018 19:13:50 +0000
Gerrit-HasComments: Yes

Reply via email to