Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10924 )
Change subject: [Java] Fix the use of resource files in tests ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10924/1/java/kudu-flume-sink/build.gradle File java/kudu-flume-sink/build.gradle: http://gerrit.cloudera.org:8080/#/c/10924/1/java/kudu-flume-sink/build.gradle@40 PS1, Line 40: generateTestAvroJava > How convenient! Yeah it's not well documented, but I eventually figured it out. http://gerrit.cloudera.org:8080/#/c/10924/1/java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala File java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala: http://gerrit.cloudera.org:8080/#/c/10924/1/java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala@38 PS1, Line 38: "/TestImportExportFiles.csv" > Why not set this to `classOf[TestImportExportFiles].getResource("/TestImpor I am keeping the constant path value simple and putting the code that derives the absolute dataPath below all in one place. -- To view, visit http://gerrit.cloudera.org:8080/10924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3a90bac67652b58f2eef802c509983c68d8a299 Gerrit-Change-Number: 10924 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 11 Jul 2018 21:39:25 +0000 Gerrit-HasComments: Yes
