Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10903 )
Change subject: KUDU-2191: downcase/normalize table names during DDL ...................................................................... KUDU-2191: downcase/normalize table names during DDL This is a followup to 7b048b8dbe which changed the catalog manager to be case preserving, but insensitive on lookup when the HMS integration is enabled. It turns out this was only possible because the HMS failed to downcase/normalize table names in notification log events[1]. This is an oversight, and probably could be considered a bug, and HMS developers have suggested that Kudu should not rely on it. After a lot of consideration I haven't been able to come up with a way to keep the case preserving semantics without changes to the HMS APIs, so instead this commit throws in the towel and adopts HMS-style case normalization during CREATE TABLE and ALTER TABLE RENAME operations. Existing tables with uppercase table names will not be altered automatically (this is consistent with the current handling of non-ascii chars in table names), so the upgrade CLI tool will be extended in a follow up commit to handle this. [1] In particular, renaming a table is problematic if the notification log listener events doesn't preserve case due to how the catalog manager / notification log listener handles table renames. Change-Id: Ie32a209d9d85851562691ddbc30f7dd02886bad7 Reviewed-on: http://gerrit.cloudera.org:8080/10903 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/integration-tests/master_hms-itest.cc M src/kudu/master/catalog_manager.cc 2 files changed, 45 insertions(+), 63 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/10903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie32a209d9d85851562691ddbc30f7dd02886bad7 Gerrit-Change-Number: 10903 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
