Hello Mike Percy, Grant Henke, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10925
to review the following change.
Change subject: tablet: add second snapshot to iterator options
......................................................................
tablet: add second snapshot to iterator options
This commit adds a second snapshot parameter called 'snap_to_exclude' and
renames the existing snapshot to 'snap_to_include'. The new snapshot is
hidden behind a boost::optional so that ignoring it is more efficient (i.e.
a call to boost::optional::is_initialized() instead of
MvccSnapshot::IsCommitted() on a snapshot including all transactions).
Taken together, the two snapshots form a time range. If both are set, the
iterator should only show transactions committed in 'snap_to_include' and
not committed in 'snap_to_exclude'. This will be used in the upcoming diff
scan API, which needs to produce results between two HT timestamps.
Change-Id: If4f7390671a637962cc2e3851e8be0e3a6982b17
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset.h
M src/kudu/tablet/tablet-test-util.h
M src/kudu/tablet/tablet.cc
12 files changed, 41 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/10925/1
--
To view, visit http://gerrit.cloudera.org:8080/10925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4f7390671a637962cc2e3851e8be0e3a6982b17
Gerrit-Change-Number: 10925
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
