Tony Foerster has posted comments on this change. ( http://gerrit.cloudera.org:8080/10902 )
Change subject: Fix flaky 'Random Backup and Restore' test ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10902/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10902/1//COMMIT_MSG@21 PS1, Line 21: Not sure of the root cause, I'd expect the timetamp obtained : from the Kudu client to work. > I would too, but only if there were rows actually written; otherwise there' The row counts are always off by one: org.apache.kudu.backup.TestKuduBackup > Random Backup and Restore FAILED java.lang.AssertionError: expected:<191> but was:<190> http://gerrit.cloudera.org:8080/#/c/10902/1/java/kudu-backup/out/test/resources/log4j.properties File java/kudu-backup/out/test/resources/log4j.properties: PS1: > What does this file do? I'm asking because it's in a non-standard Maven loc My mistake, this should not have been committed. I'm not sure why the non-standard 'out' location, I thought it just hadn't been added to the .gitignore. Not sure what command I ran to create it. -- To view, visit http://gerrit.cloudera.org:8080/10902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51a6dbeeb064dff157609fdbbafe505668eb2b26 Gerrit-Change-Number: 10902 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Foerster <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tony Foerster <[email protected]> Gerrit-Comment-Date: Thu, 12 Jul 2018 13:29:10 +0000 Gerrit-HasComments: Yes
