Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10839 )
Change subject: spark: Expose socketReadTimeoutMs to Spark connector ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/10839/3/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/10839/3/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@91 PS3, Line 91: sc.register(timestampAccumulator) > Oh I didn't notice that asyncClient is a lazy val. Done, except I just impl Sounds good, that's probably better for binary compatibility. http://gerrit.cloudera.org:8080/#/c/10839/3/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@111 PS3, Line 111: override def run(): Array[Byte] = syncClient.exportAuthenticationCredentials() > It was already there but I've removed it. ah ok, thanks. http://gerrit.cloudera.org:8080/#/c/10839/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/10839/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@22 PS4, Line 22: import com.google.common.annotations.VisibleForTesting Remove this for same reason as in other review. -- To view, visit http://gerrit.cloudera.org:8080/10839 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ab0ff0b242790caffb7e2848958148ffe547c4d Gerrit-Change-Number: 10839 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Fri, 13 Jul 2018 00:40:49 +0000 Gerrit-HasComments: Yes
