Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10938 )
Change subject: [tools] ignore SIGPIPE in kudu CLI ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10938/1/src/kudu/tools/tool_main.cc File src/kudu/tools/tool_main.cc: http://gerrit.cloudera.org:8080/#/c/10938/1/src/kudu/tools/tool_main.cc@268 PS1, Line 268: kudu::InitGoogleLoggingSafe(argv[0]); > Doesn't this already lead to an IgnoreSigPipe call? I don't think so since the kudu CLI tool was exiting on SIGPIPE if during that TserverGoesDownDuringRebalancingTest. Probably, logging was already initialized at that point? At least, after adding that IgnoreSigPipe() the issue with SIGPIPE during TserverGoesDownDuringRebalancingTest went away. -- To view, visit http://gerrit.cloudera.org:8080/10938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I379376e7856a167b590f90c20f82402f2b825db9 Gerrit-Change-Number: 10938 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 13 Jul 2018 20:23:27 +0000 Gerrit-HasComments: Yes
