Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10946 )
Change subject: [logging] fix logging init if linking in kudu client library ...................................................................... Patch Set 1: > > imagine someone has linked against the exported library and then > called InitGoogleLoggingSafe(), expecting all that extra > initialization to happen > > That isn't really possible because the InitGoogleLogging* functions > aren't exported APIs and we don't export glog symbols. So, even if > the user happens to also use glog, they'll have a different set of > glog symbols and state, so there wouldn't be any conflict. All right, that makes sense -- I missed the point about non-exported logging initialization functions. I'll re-do the patch then, thanks. -- To view, visit http://gerrit.cloudera.org:8080/10946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9438248e7f9699cf14d648160d9d516ab27d6ca2 Gerrit-Change-Number: 10946 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 16 Jul 2018 19:51:09 +0000 Gerrit-HasComments: No
