Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10907 )
Change subject: Add support for running Java tests in dist-test ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/10907/6/build-support/java-home-candidates.txt File build-support/java-home-candidates.txt: PS6: > Should probably add a license header and a brief description of what this f Done http://gerrit.cloudera.org:8080/#/c/10907/3/build-support/run_dist_test.py File build-support/run_dist_test.py: http://gerrit.cloudera.org:8080/#/c/10907/3/build-support/run_dist_test.py@179 PS3, Line 179: if __name__ == "__main__": > Don't the Java tests always use the binaries from build/latest? The `latest` symlink is not marked as a dependency directory so it's not sent to each dist-test task. I am not sure we would want to either. http://gerrit.cloudera.org:8080/#/c/10907/3/java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java File java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java: http://gerrit.cloudera.org:8080/#/c/10907/3/java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java@73 PS3, Line 73: public void addTestTask(Test t) { > OK, could you add a comment explaining that? Done -- To view, visit http://gerrit.cloudera.org:8080/10907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I446a15192a45e296b323a4c7d305f236e22ab557 Gerrit-Change-Number: 10907 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 17 Jul 2018 15:28:08 +0000 Gerrit-HasComments: Yes
