Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10983 )
Change subject: WIP: KUDU-1291 Efficiently support predicates on non-prefix key components ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10983/1/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: http://gerrit.cloudera.org:8080/#/c/10983/1/src/kudu/tablet/cfile_set.cc@669 PS1, Line 669: } while( (key_iter_->GetCurrentOrdinal()) < (cur_idx_ + prepared_count_)); instead of this loop, I wonder if we can instead "peek" at the last value scanned in this batch and reconstruct the last PK so we can seek from there, instead of incrementing by 1 on line 652. -- To view, visit http://gerrit.cloudera.org:8080/10983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I230cd5a288e28ace796b352a603e0d1bcc1e4e0f Gerrit-Change-Number: 10983 Gerrit-PatchSet: 1 Gerrit-Owner: Anupama Gupta <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 18 Jul 2018 21:22:41 +0000 Gerrit-HasComments: Yes
