Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10802 )
Change subject: tablet: encapsulate common iterator options ...................................................................... tablet: encapsulate common iterator options I intend to introduce an additional option or two as part of the "diff scan" API. To that end, this patch knocks the plumbing out of the way by moving all of the common iterator options into a new struct. Unfortunately, I can't use it in Tablet::NewRowIterator because while nearly every iterator expects a pointer to the projection, Tablet::Iterator stores a copy of the projection itself. Change-Id: I7232d163436e69999bba75ed66756d2a86c5a959 Reviewed-on: http://gerrit.cloudera.org:8080/10802 Tested-by: Adar Dembo <[email protected]> Reviewed-by: Mike Percy <[email protected]> --- M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_compaction-test.cc M src/kudu/tablet/delta_iterator_merger.cc M src/kudu/tablet/delta_iterator_merger.h M src/kudu/tablet/delta_store.h M src/kudu/tablet/delta_tracker.cc M src/kudu/tablet/delta_tracker.h M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/deltafile.cc M src/kudu/tablet/deltafile.h M src/kudu/tablet/deltamemstore-test.cc M src/kudu/tablet/deltamemstore.cc M src/kudu/tablet/deltamemstore.h M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/memrowset.cc M src/kudu/tablet/memrowset.h M src/kudu/tablet/mock-rowsets.h M src/kudu/tablet/mt-rowset_delta_compaction-test.cc M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h 27 files changed, 272 insertions(+), 246 deletions(-) Approvals: Adar Dembo: Verified Mike Percy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/10802 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7232d163436e69999bba75ed66756d2a86c5a959 Gerrit-Change-Number: 10802 Gerrit-PatchSet: 7 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
