Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10929 )
Change subject: memrowset: support iteration with omit_deleted_rows=false ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10929/3/src/kudu/tablet/memrowset-test.cc File src/kudu/tablet/memrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/10929/3/src/kudu/tablet/memrowset-test.cc@618 PS3, Line 618: omit > maybe include instead of omit to avoid setting true for a negative? Done -- To view, visit http://gerrit.cloudera.org:8080/10929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie018043518b437ecc719cf9f87b2c5eea560c9a1 Gerrit-Change-Number: 10929 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 19 Jul 2018 20:36:53 +0000 Gerrit-HasComments: Yes
