Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11017 )
Change subject: Add alter_external_catalogs flag to table rename tool ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11017/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11017/1/src/kudu/client/client.h@68 PS1, Line 68: Status AlterKuduTableOnly(client::KuduClient* kudu_client, It would be a lot cleaner to have a method in tool_action_common that sets the option on a KuduTableAlterer, then only one method needs to be a friend here. -- To view, visit http://gerrit.cloudera.org:8080/11017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f5d97f234283b7740df727e085523c7f0b09735 Gerrit-Change-Number: 11017 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 23 Jul 2018 22:20:50 +0000 Gerrit-HasComments: Yes
