Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11032 )
Change subject: [tablet] clean-up on replay of WAL entries ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11032/1/src/kudu/consensus/log-test.cc File src/kudu/consensus/log-test.cc: http://gerrit.cloudera.org:8080/#/c/11032/1/src/kudu/consensus/log-test.cc@293 PS1, Line 293: // TODO(unknown): put this in TearDown() with a test on log state? > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/11032/1/src/kudu/consensus/log_util.h File src/kudu/consensus/log_util.h: http://gerrit.cloudera.org:8080/#/c/11032/1/src/kudu/consensus/log_util.h@208 PS1, Line 208: // the log entries read up to the corrupted one are returned in the 'entries' > You could use LogEntries here too, if you're willing to define it outside o Done http://gerrit.cloudera.org:8080/#/c/11032/1/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: http://gerrit.cloudera.org:8080/#/c/11032/1/src/kudu/tablet/tablet_bootstrap.cc@473 PS1, Line 473: string debug_str = entry_debug_info; > Remove this? Done -- To view, visit http://gerrit.cloudera.org:8080/11032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie39516b09e4c756e8af1d8e1a5604672c96a80cb Gerrit-Change-Number: 11032 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 24 Jul 2018 20:02:04 +0000 Gerrit-HasComments: Yes
