Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11016 )
Change subject: Allow non-HMS compatible tables to be renamed after turning on HMS integration ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11016/2/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/11016/2/src/kudu/integration-tests/master_hms-itest.cc@585 PS2, Line 585: TEST_F(MasterHmsUpgradeTest, TestRenameExistingTables) { > I believe that's covered by 'TestConflictingNormalizedNames' above, or is t Sorry, missed that. LGTM. -- To view, visit http://gerrit.cloudera.org:8080/11016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If554efbda06e33b5fdb40565e700bad8a306c143 Gerrit-Change-Number: 11016 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 24 Jul 2018 21:09:24 +0000 Gerrit-HasComments: Yes
