Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10929 )
Change subject: memrowset: support iteration with include_deleted_rows ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/10929/5/src/kudu/tablet/memrowset-test.cc File src/kudu/tablet/memrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/10929/5/src/kudu/tablet/memrowset-test.cc@585 PS5, Line 585: INSTANTIATE_TEST_CASE_P(MrsConfigurations, ParameterizedTestMemRowSet, : ::testing::Bool()); > mind naming this parameterization something more useful to indicate what th Done http://gerrit.cloudera.org:8080/#/c/10929/5/src/kudu/tablet/memrowset-test.cc@665 PS5, Line 665: ASSERT_OK(InsertRow(mrs.get(), "row 1", 0)); > I think its' worth adding a third row which has been inserted, deleted, and Done http://gerrit.cloudera.org:8080/#/c/10929/5/src/kudu/tablet/memrowset.h File src/kudu/tablet/memrowset.h: http://gerrit.cloudera.org:8080/#/c/10929/5/src/kudu/tablet/memrowset.h@557 PS5, Line 557: // The 'was_deleted' parameter will be set to true if the last mutation walked > ah, this is starting to look a bit closer to my proposal to add an enum out Technically they're all possible, but I think this is still cleaner with your enum suggestion from the first patch. Take a look. -- To view, visit http://gerrit.cloudera.org:8080/10929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie018043518b437ecc719cf9f87b2c5eea560c9a1 Gerrit-Change-Number: 10929 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 25 Jul 2018 02:30:33 +0000 Gerrit-HasComments: Yes
