Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11030 )
Change subject: Scala code formatting with Scalafmt ...................................................................... Patch Set 11: (1 comment) As mentioned earlier, I still think it's important to add the Maven plugin too. http://gerrit.cloudera.org:8080/#/c/11030/11/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/11030/11/build-support/jenkins/build-and-test.sh@392 PS11, Line 392: GRADLE_FLAGS="$GRADLE_FLAGS -Dfile.encoding=UTF-8 --console=plain --no-daemon --continue -DrerunFailingTestsCount=3" I think you can define this in the gradle build itself by adding this to gradle.properties: `systemProp.file.encoding = UTF-8` Ideally the plugin would let us pass the existing encoding property. But I don't see that option. -- To view, visit http://gerrit.cloudera.org:8080/11030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac96383d88394084e19712177d05f9fc63de766c Gerrit-Change-Number: 11030 Gerrit-PatchSet: 11 Gerrit-Owner: Tony Foerster <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tony Foerster <[email protected]> Gerrit-Comment-Date: Thu, 26 Jul 2018 15:18:56 +0000 Gerrit-HasComments: Yes
