Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11046 )
Change subject: [kudu-admin-test] improvements on error reporting ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11046/2/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/11046/2/src/kudu/tools/kudu-admin-test.cc@1336 PS2, Line 1336: if (out) { : str << " stdout: " << *out; : } : if (err) { : str << " stderr: " << *err; : } Seems like these are always non-null, in which case maybe use `const string&` and always attach them to `str`? Also how does the output look? Maybe would it help to separate with some newlines or do extra formatting? -- To view, visit http://gerrit.cloudera.org:8080/11046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfa74d5a78e89bf7ff1a0e914384999466460145 Gerrit-Change-Number: 11046 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Sat, 28 Jul 2018 17:49:51 +0000 Gerrit-HasComments: Yes
