Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11089 )
Change subject: [Java] Minor fixes to the Scalafmt changes ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11089/2/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/11089/2/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@149 PS2, Line 149: Objects.equal(before.isNullable, after.isNullable) && > Why not indent this? According to the docs for the corresponding scalafmt setting for this, this is the context: https://github.com/scala-js/scala-js/blob/master/CODINGSTYLE.md#long-expressions-with-binary-operators I guess this is reasonable. -- To view, visit http://gerrit.cloudera.org:8080/11089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc Gerrit-Change-Number: 11089 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tony Foerster <[email protected]> Gerrit-Comment-Date: Tue, 31 Jul 2018 21:30:41 +0000 Gerrit-HasComments: Yes
