Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11063 )
Change subject: KUDU-2509 fix use-after-free in case of WAL replay error ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11063/1/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: http://gerrit.cloudera.org:8080/#/c/11063/1/src/kudu/tablet/tablet_bootstrap.cc@985 PS1, Line 985: RETURN_NOT_OK > Won't this leak on error applying the commit? In that case shouldn't we use No, it will not leak -- the upper-level code in TabletBootstrap::PlaySegments() takes care of that. Also, that if that was the case that would be caught in ASAN build while running the BootstrapTest.TestKudu2509 test scenario. Just FYI: in the main trunk there was an additional clean-up changelist that makes the passing of the ownership of the entry more robust. -- To view, visit http://gerrit.cloudera.org:8080/11063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.7.x Gerrit-MessageType: comment Gerrit-Change-Id: I11373b1cc34d9e2e0181bee2d3841b49022218ed Gerrit-Change-Number: 11063 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 31 Jul 2018 23:30:27 +0000 Gerrit-HasComments: Yes
