Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11036 )
Change subject: hms tools: do not require HMS configuration flags ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/11036/12/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/11036/12/src/kudu/tools/tool_action_hms.cc@135 PS12, Line 135: CHECK(hms_sasl_enabled != flags.end()); Just curious: why it's not an option to have DCHECK() instead of CHECK() here and returning Status::ConfigurationError() or Status::IllegalState() if hms_sasl_enabled? http://gerrit.cloudera.org:8080/#/c/11036/12/src/kudu/tools/tool_action_hms.cc@692 PS12, Line 692: .AddOptionalParameter("hive_metastore_sasl_enabled", boost::none, kHmsSaslEnabledDesc) : .AddOptionalParameter("hive_metastore_uris", boost::none, kHmsUrisDesc) It might be mentioned elsewhere, but it seems I missed that and could not find the answer: why these parameters are present for 'fix' and 'downgrade' sub-commands but absent in the 'check' sub-command? Could you clarify? -- To view, visit http://gerrit.cloudera.org:8080/11036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf580384a1612174a75142295d7f604cd6fabfe1 Gerrit-Change-Number: 11036 Gerrit-PatchSet: 12 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 01 Aug 2018 01:05:47 +0000 Gerrit-HasComments: Yes
