Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11112 )
Change subject: [no review] Base to unblock threads of location awareness work ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11112/1/src/kudu/master/ts_descriptor.h File src/kudu/master/ts_descriptor.h: http://gerrit.cloudera.org:8080/#/c/11112/1/src/kudu/master/ts_descriptor.h@123 PS1, Line 123: const boost::optional<std::string>& This should return a copy since the location can change if the tablet server re-registers. -- To view, visit http://gerrit.cloudera.org:8080/11112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38efb0acd94ed00b355c106875b9bb6c57ae2915 Gerrit-Change-Number: 11112 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 02 Aug 2018 23:14:16 +0000 Gerrit-HasComments: Yes
