Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11121 )
Change subject: Add unstable client APIs to fetch HMS integration configuration status ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/11121/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/11121/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@834 PS1, Line 834: recently connected most recent connection? http://gerrit.cloudera.org:8080/#/c/11121/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@846 PS1, Line 846: authentication data Wrong comment? http://gerrit.cloudera.org:8080/#/c/11121/1/java/kudu-client/src/main/java/org/apache/kudu/client/HiveMetastoreConfig.java File java/kudu-client/src/main/java/org/apache/kudu/client/HiveMetastoreConfig.java: http://gerrit.cloudera.org:8080/#/c/11121/1/java/kudu-client/src/main/java/org/apache/kudu/client/HiveMetastoreConfig.java@26 PS1, Line 26: Impala Do you foresee this been used by other project? http://gerrit.cloudera.org:8080/#/c/11121/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKuduCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKuduCluster.java: http://gerrit.cloudera.org:8080/#/c/11121/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKuduCluster.java@100 PS1, Line 100: assertNotNull(client.getHiveMetastoreConfig()); Also assert the content? http://gerrit.cloudera.org:8080/#/c/11121/1/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/11121/1/src/kudu/master/master.proto@671 PS1, Line 671: Address Address(es)? http://gerrit.cloudera.org:8080/#/c/11121/1/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/11121/1/src/kudu/tools/tool.proto@45 PS1, Line 45: // Whether or not the cluster should be integrated with a Hive Metastore. > I don't understand this. Isn't this bool less expressive than hms_mode? And +1, not sure why do we need to add this? -- To view, visit http://gerrit.cloudera.org:8080/11121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb89787ed35c41e85f1d9bf953c4c228dcafcdb Gerrit-Change-Number: 11121 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 10 Aug 2018 23:43:28 +0000 Gerrit-HasComments: Yes
