Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11216 )
Change subject: KUDU-2540: Authorization failures on exactly-once RPCs cause FATAL ...................................................................... Patch Set 2: (1 comment) > Patch Set 1: Code-Review+2 > > Are you going to backport this to all affected branches? I'm planning on backporting back at least two releases. If you think we should do more let me know, I don't expect there to be conflicts. http://gerrit.cloudera.org:8080/#/c/11216/1/src/kudu/rpc/service_if.cc File src/kudu/rpc/service_if.cc: http://gerrit.cloudera.org:8080/#/c/11216/1/src/kudu/rpc/service_if.cc@121 PS1, Line 121: ResultTracker::RpcState state = ctx->result_tracker( > nit while you are here: is this variable needed? Done -- To view, visit http://gerrit.cloudera.org:8080/11216 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9717d36e438bbe68172fa2619c9829ad5fdc779d Gerrit-Change-Number: 11216 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 14 Aug 2018 20:38:38 +0000 Gerrit-HasComments: Yes
