Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11100 )
Change subject: Implement BloomFilter Predicate in server side. ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.h File src/kudu/common/column_predicate.h: http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.h@67 PS4, Line 67: InBloomFilter, nit: I think 'BloomFilter' is shorter and just as clear. The 'In' part of InList comes from the SQL IN syntax, which isn't at play here. http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.h@286 PS4, Line 286: // Returns the nhash of bloom filter if this is a bloom filter predicate. Add a space above. Is the comment correct, what's 'nhash'? http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.cc@42 PS4, Line 42: ColumnPredicate::ColumnPredicate(PredicateType predicate_type, (meta-comment) If I understand the changes to this file correctly, Range predicates can now have an attached set of bloom filters? If so I think this may be the wrong way to go about it, instead I think it would be cleaner to say that BloomFilter predicates can have an optional upper and lower bound. In other words, if the bfs vector is non-empty then it must be a BloomFilter predicate type. http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.cc@460 PS4, Line 460: for (auto value : values_) { Simplify with std::copy_if or something equivalent. http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.cc@563 PS4, Line 563: for (auto value : values_) { likewise -- To view, visit http://gerrit.cloudera.org:8080/11100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62c2de42667d0255d94e19db773240f7f9ee636c Gerrit-Change-Number: 11100 Gerrit-PatchSet: 4 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Wed, 15 Aug 2018 00:32:30 +0000 Gerrit-HasComments: Yes
