Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11238 )
Change subject: [site] KUDU-1951 Exclude dirs from site_tool proof ...................................................................... Patch Set 2: (1 comment) > Patch Set 2: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/11238/2/site_tool File site_tool: http://gerrit.cloudera.org:8080/#/c/11238/2/site_tool@124 PS2, Line 124: '--file-ignore', '/apidocs|releases|configuration_ref|cpp-client-api|www/', > I don't feel that strongly, I just think that at some point you'll end up w well, those are tracked under master branch, so whenever you checkout gh-pages, they'll just disappear. the problem with www for example, and build and thirdparty on the other patch, is that they are all untracked, so if you check out gh-pages in the some directory/worktree, you need to rm or sideline them to avoid breaking these scripts -- To view, visit http://gerrit.cloudera.org:8080/11238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Iee421e4e218d40cef87db1e3f04991113afe596d Gerrit-Change-Number: 11238 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 15 Aug 2018 22:12:11 +0000 Gerrit-HasComments: Yes
