Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11207 )
Change subject: [master] replica selection honors placement policy ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/11207/3/src/kudu/master/placement_policy.cc File src/kudu/master/placement_policy.cc: http://gerrit.cloudera.org:8080/#/c/11207/3/src/kudu/master/placement_policy.cc@254 PS3, Line 254: avalailable available http://gerrit.cloudera.org:8080/#/c/11207/3/src/kudu/master/placement_policy.cc@256 PS3, Line 256: table tablet http://gerrit.cloudera.org:8080/#/c/11207/3/src/kudu/master/placement_policy.cc@264 PS3, Line 264: break; This loop combo is a little tricky. It took me a bit of thinking to see why we couldn't get stuck here. Could you add a comment about why we break / return at each point (except the one at L270 that's obvious) so it's clearer why we won't get stuck? -- To view, visit http://gerrit.cloudera.org:8080/11207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4169098abf17d5591d4c1675561afc15b5477fcd Gerrit-Change-Number: 11207 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Thu, 16 Aug 2018 21:19:59 +0000 Gerrit-HasComments: Yes
