Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11248 )
Change subject: KUDU-2469 pt 1: add an IOContext ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11248/1/src/kudu/fs/io_context.h File src/kudu/fs/io_context.h: http://gerrit.cloudera.org:8080/#/c/11248/1/src/kudu/fs/io_context.h@33 PS1, Line 33: // Utility class used to pass strings across many layers, avoiding excessive : // plumbing. > I don't think plumbing into the constructor makes sense; wasn't one of the Right, one of the original concerns that plumbing new state down through all the layers would be expensive if we ended up storing eg the tablet id in the CFileReaders. I thought maybe it could be less expensive by keeping a single object at the Tablet layer, and piping it down via a shared_ptr or somesuch, but that's not nearly as extendible as what you're describing. That "initiator"/"performer" concern is definitely valid, I tried to allude to it in the comments below, but wasn't explicit about the details of how it is used in the next patch. I think I'll bite the bullet and plumb through the iterator and the additional methods (FindRow(), CFileSet::Open(), etc.). -- To view, visit http://gerrit.cloudera.org:8080/11248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I645e10a2fda1f2564326b7052e6a0debc5ad738c Gerrit-Change-Number: 11248 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 17 Aug 2018 23:42:03 +0000 Gerrit-HasComments: Yes
