Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11266 )
Change subject: bitmap: add equality method ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11266/1/src/kudu/util/bitmap-test.cc File src/kudu/util/bitmap-test.cc: http://gerrit.cloudera.org:8080/#/c/11266/1/src/kudu/util/bitmap-test.cc@241 PS1, Line 241: for (int i = num_bits - 1; i >= 0; i--) { Should this also test equality when bit values are 1? -- To view, visit http://gerrit.cloudera.org:8080/11266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If53e41250435501e158bdbc076dc8e89ea153256 Gerrit-Change-Number: 11266 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 20 Aug 2018 16:49:34 +0000 Gerrit-HasComments: Yes
