Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11273 )
Change subject: [hms] Add Hcatalog jars to the HMS classpath ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11273/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11273/1//COMMIT_MSG@11 PS1, Line 11: lisenter listener http://gerrit.cloudera.org:8080/#/c/11273/1//COMMIT_MSG@12 PS1, Line 12: added adds http://gerrit.cloudera.org:8080/#/c/11273/1/src/kudu/hms/mini_hms.cc File src/kudu/hms/mini_hms.cc: http://gerrit.cloudera.org:8080/#/c/11273/1/src/kudu/hms/mini_hms.cc@119 PS1, Line 119: string hcatalog_jars = Substitute("$0/hcatalog/share/hcatalog/*", hive_home); : string aux_jars = Substitute("$0/hms-plugin.jar,$1", bin_dir, hcatalog_jars); Nit: I think it's clearer if combined: string aux_jars = Substitute("$0/hms-plugin.jar,$1/hcatalog/share/hcatalog/*", bin_dir, hive_home); If/when the list gets longer, we should treat it as a list, set it up entry by entry, and then join it together. -- To view, visit http://gerrit.cloudera.org:8080/11273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0 Gerrit-Change-Number: 11273 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 20 Aug 2018 19:53:43 +0000 Gerrit-HasComments: Yes
