Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11290 )
Change subject: [webui] Make the tables on /tablets fancy ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/11290/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11290/2//COMMIT_MSG@11 PS2, Line 11: paginated and searchable > Nice! Any page. I tested by searching for table names and tablet ids not on the current page. http://gerrit.cloudera.org:8080/#/c/11290/2//COMMIT_MSG@29 PS2, Line 29: 1: https://github.com/wenzhixin/bootstrap-table > nit: I think this should precede the Change-Id metastring. Done http://gerrit.cloudera.org:8080/#/c/11290/2/www/bootstrap/css/bootstrap-table.min.css File www/bootstrap/css/bootstrap-table.min.css: PS2: > Is this also from the bootstrap table? If so, maybe add license and update Done http://gerrit.cloudera.org:8080/#/c/11290/2/www/bootstrap/js/bootstrap-table.min.js File www/bootstrap/js/bootstrap-table.min.js: PS2: > I think it's necessary to update build-support/release/rat_exclude_files.tx Done http://gerrit.cloudera.org:8080/#/c/11290/2/www/tablets.mustache File www/tablets.mustache: http://gerrit.cloudera.org:8080/#/c/11290/2/www/tablets.mustache@98 PS2, Line 98: <td>{{last_status}}</td> > Is it needed now? Done -- To view, visit http://gerrit.cloudera.org:8080/11290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5243e9cb839e75936c71b14fed08881317ee0f5f Gerrit-Change-Number: 11290 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 22 Aug 2018 20:54:50 +0000 Gerrit-HasComments: Yes
