Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11301 )
Change subject: Enable iwyu on hms files ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11301/1/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/11301/1/src/kudu/hms/hms_catalog.cc@25 PS1, Line 25: #include <iterator> > Nit: out of order (why didn't tidy or iwyu flag this? Can you investigate?) I think that's a function of tidy, but I'm not sure where to look about why it didn't since it's not something I can run locally afaik. -- To view, visit http://gerrit.cloudera.org:8080/11301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d4a5b23683b4fbec12fa86c24d997677ee3113a Gerrit-Change-Number: 11301 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 23 Aug 2018 21:08:50 +0000 Gerrit-HasComments: Yes
