Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11307 )
Change subject: Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11307/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11307/1//COMMIT_MSG@7 PS1, Line 7: Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse Nit: Line breaks. With a short summary and then detailed message. http://gerrit.cloudera.org:8080/#/c/11307/1/java/gradle/protobuf.gradle File java/gradle/protobuf.gradle: http://gerrit.cloudera.org:8080/#/c/11307/1/java/gradle/protobuf.gradle@42 PS1, Line 42: entries += new SourceFolder('target/generated-sources/protobuf/java', null) This is pointing to the files generated by the maven build. To ensure you are not mixing builds run `mvn clean` to clear out the target directories. I think you should use "${protobuf.generatedFilesBaseDir}/main/java" which is effectively "build/generated/source/proto/main/java" -- To view, visit http://gerrit.cloudera.org:8080/11307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f322bc080838f99096b7e5b17f4c313a2ca1a54 Gerrit-Change-Number: 11307 Gerrit-PatchSet: 1 Gerrit-Owner: Greg Solovyev <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 23 Aug 2018 21:17:42 +0000 Gerrit-HasComments: Yes
