Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11303 )
Change subject: error_manager: rename error types ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11303/1/src/kudu/fs/error_manager.cc File src/kudu/fs/error_manager.cc: http://gerrit.cloudera.org:8080/#/c/11303/1/src/kudu/fs/error_manager.cc@44 PS1, Line 44: InsertOrUpdate(&callbacks_, e, std::move(cb)); > warning: passing result of std::move() as a const reference argument; no mo You're going to need to use EmplaceOrUpdate here, or add it to map-util.h if it doesn't exist. -- To view, visit http://gerrit.cloudera.org:8080/11303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I377904ee51bb0f7b0f1104d7a4723f74d52e6e3f Gerrit-Change-Number: 11303 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 24 Aug 2018 18:01:35 +0000 Gerrit-HasComments: Yes
