Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11342 )
Change subject: build-support: option to retry all failed tests ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/11342/4/build-support/dist_test.py File build-support/dist_test.py: http://gerrit.cloudera.org:8080/#/c/11342/4/build-support/dist_test.py@347 PS4, Line 347: '-e', 'KUDU_COMPRESS_TEST_OUTPUT=%s' % \ > I don't think this is needed. dist-test will handle the retries when creati Ah right, and it wasn't doing anything in rev4 because KUDU_FLAKY_TEST_ATTEMPTS isn't passed in. http://gerrit.cloudera.org:8080/#/c/11342/4/build-support/dist_test.py@405 PS4, Line 405: }] * replicate_tasks > This is where the dist-test retries are handled. Ack http://gerrit.cloudera.org:8080/#/c/11342/4/src/kudu/fs/data_dirs-test.cc File src/kudu/fs/data_dirs-test.cc: http://gerrit.cloudera.org:8080/#/c/11342/4/src/kudu/fs/data_dirs-test.cc@442 PS4, Line 442: } > We should remove this in the patch. (coneofshame) -- To view, visit http://gerrit.cloudera.org:8080/11342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24aea0b9e7a1c2c66bc5feffcb454ff01cdca6fd Gerrit-Change-Number: 11342 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 28 Aug 2018 14:58:36 +0000 Gerrit-HasComments: Yes
