Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11343 )
Change subject: build: different libunwind workaround for 0dc19bfb3 ...................................................................... build: different libunwind workaround for 0dc19bfb3 Rather than add libunwind to the gutil test dependency list twice (once explicitly, and once via KUDU_BASE_LIBS), let's express it as a dependency of glog. That'll cause cmake to adjust the link order based on the new dependency graph, and place libunwind early enough that glog can resolve symbols in it. I tested this by building the two gutil tests in release mode. After removing the workaround from gutil/CMakeLists.txt, they failed to build. With the new dependency information, they build successfully. Change-Id: I18325dbbddf82f8bad7d7b9bf759487811396ff3 Reviewed-on: http://gerrit.cloudera.org:8080/11343 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <aser...@cloudera.com> --- M CMakeLists.txt M src/kudu/gutil/CMakeLists.txt 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I18325dbbddf82f8bad7d7b9bf759487811396ff3 Gerrit-Change-Number: 11343 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins
