Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11029 )
Change subject: deltamemstore: support iteration with snap_to_exclude ...................................................................... Patch Set 9: (7 comments) http://gerrit.cloudera.org:8080/#/c/11029/9/src/kudu/tablet/deltamemstore-test.cc File src/kudu/tablet/deltamemstore-test.cc: http://gerrit.cloudera.org:8080/#/c/11029/9/src/kudu/tablet/deltamemstore-test.cc@142 PS9, Line 142: * > nit: move the asterisk next to the type Done http://gerrit.cloudera.org:8080/#/c/11029/9/src/kudu/tablet/deltamemstore-test.cc@579 PS9, Line 579: TEST_F(TestDeltaMemStore, TestScanSnapToExclude) { > Mind adding a comment describing this test? Maybe something like: Test to e Done http://gerrit.cloudera.org:8080/#/c/11029/9/src/kudu/tablet/deltamemstore-test.cc@585 PS9, Line 585: // Sequence of operations: > nit: Consider moving this part of the code down below the definition of App Done http://gerrit.cloudera.org:8080/#/c/11029/9/src/kudu/tablet/deltamemstore-test.cc@591 PS9, Line 591: snaps.emplace_back(mvcc_); > nit: to make this easier to verify by inspection, mind adding // snaps[0] t Done http://gerrit.cloudera.org:8080/#/c/11029/9/src/kudu/tablet/deltamemstore-test.cc@592 PS9, Line 592: 0 > nit: mind adding a const rowid_t kRowId = 0 up above so we can use it throu Done http://gerrit.cloudera.org:8080/#/c/11029/9/src/kudu/tablet/deltamemstore-test.cc@600 PS9, Line 600: auto ApplyAndCheck = [&](const MvccSnapshot& exclude, > Please add a doc comment along these lines to this lambda: Done http://gerrit.cloudera.org:8080/#/c/11029/9/src/kudu/tablet/deltamemstore-test.cc@633 PS9, Line 633: false > nit: mind changing this to /*is_row_live=*/ false ? Or maybe use an enum bu Gonna skip this because a follow-on patch replaces this with a tri-state enum. -- To view, visit http://gerrit.cloudera.org:8080/11029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04af3737960f3fcc7b1921a77ff91e1607b7bc47 Gerrit-Change-Number: 11029 Gerrit-PatchSet: 9 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 28 Aug 2018 22:02:28 +0000 Gerrit-HasComments: Yes
