Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11303 )
Change subject: error_manager: rename error types ...................................................................... error_manager: rename error types The previous ErrorHandlerType enum names weren't very descriptive, and reflected the expected error handling (e.g. fail a disk, fail a tablet), rather than the error itself. In preparation of adding a new error ErrorHandlerType for CFile checksum errors, this patch attempts to clarify usage of the FsErrorManager. As I intend on adding another error type, I updated the error manager to use a map to store its error-handling callbacks, and added a map utility function to facilitate this. Change-Id: I377904ee51bb0f7b0f1104d7a4723f74d52e6e3f Reviewed-on: http://gerrit.cloudera.org:8080/11303 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/fs/error_manager-test.cc M src/kudu/fs/error_manager.cc M src/kudu/fs/error_manager.h M src/kudu/fs/file_block_manager.cc M src/kudu/fs/fs_manager.cc M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/gutil/map-util.h M src/kudu/tserver/tablet_server.cc M src/kudu/util/map-util-test.cc 10 files changed, 120 insertions(+), 108 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I377904ee51bb0f7b0f1104d7a4723f74d52e6e3f Gerrit-Change-Number: 11303 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
