Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11266 )
Change subject: bitmap: add equality method ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/11266/4/src/kudu/util/bitmap-test.cc File src/kudu/util/bitmap-test.cc: http://gerrit.cloudera.org:8080/#/c/11266/4/src/kudu/util/bitmap-test.cc@231 PS4, Line 231: TEST(TestBitMap, TestEquals) { > Does it make sense to add a test for overlapping bitmaps as well? Done http://gerrit.cloudera.org:8080/#/c/11266/4/src/kudu/util/bitmap-test.cc@254 PS4, Line 254: i > Should this be (i + 1)? Oops, yes. -- To view, visit http://gerrit.cloudera.org:8080/11266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If53e41250435501e158bdbc076dc8e89ea153256 Gerrit-Change-Number: 11266 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 30 Aug 2018 19:24:07 +0000 Gerrit-HasComments: Yes