Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11361 )
Change subject: Add some additional info to ScanRequest traces ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/11361/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/11361/2/src/kudu/tablet/tablet.cc@1790 PS2, Line 1790: TRACE_COUNTER_INCREMENT("rowset_iterators", ret.size()); nit: could these be coalesced and put down in the Tablet::Iterator right after the call to CaptureConsistentIterators at L2323? -- To view, visit http://gerrit.cloudera.org:8080/11361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61792b6989c54a4e0578fe9255d769fe071e52f8 Gerrit-Change-Number: 11361 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 30 Aug 2018 20:37:56 +0000 Gerrit-HasComments: Yes
